Messages in this thread | | | Date | Thu, 1 Dec 2022 12:02:00 +0100 | Subject | Re: [PATCH v2 1/9] dt-bindings: serial: add documentation for Bouffalolab UART Driver | From | Krzysztof Kozlowski <> |
| |
On 27/11/2022 14:24, Jisheng Zhang wrote: > Add bindings doc for Bouffalolab UART Driver > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > .../bindings/serial/bouffalolab,uart.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > > diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > new file mode 100644 > index 000000000000..a8293444ca31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml
Name the file matching compatible, so bouffalolab,bl808-uart.yaml
> @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bouffalolab UART Controller > + > +maintainers: > + - Jisheng Zhang <jszhang@kernel.org> > + > +allOf: > + - $ref: serial.yaml# > + > +properties: > + compatible: > + const: bouffalolab,bl808-uart
Rob's comments from v1 are applicable. Either fix or respond to them.
> + > + reg: > + maxItems: 1 > +
Best regards, Krzysztof
| |