Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2] clocksource: ingenic-ost: define pm functions properly in platform_driver struct | Date | Thu, 01 Dec 2022 12:00:00 +0100 |
| |
Lukas!
On Wed, Nov 23 2022 at 09:31, Lukas Bulwahn wrote: > Commit ca7b72b5a5f2 ("clocksource: Add driver for the Ingenic JZ47xx OST") > adds the struct platform_driver ingenic_ost_driver, with the definition of > pm functions under the non-existing config PM_SUSPEND, which means the > intended pm functions were never actually included in any build. > > As the only callbacks are .suspend_noirq and .resume_noirq, we can assume > that it is intended to be CONFIG_PM_SLEEP. > > Since commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate > old ones"), the default pattern for platform_driver definitions > conditional for CONFIG_PM_SLEEP is to use pm_sleep_ptr(). > > As __maybe_unused annotations on the dev_pm_ops structure and its callbacks > are not needed anymore, remove these as well. > > Suggested-by: Paul Cercueil <paul@crapouillou.net> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
just a minor nit. The subsystem prefix should be:
clocksource/drivers/ingenic-ost:
git log --one-line $FILE is usually a good hint for the subsystem specific prefix choice.
Fixed it up while applying.
Thanks,
tglx
| |