Messages in this thread | | | From | Oded Gabbay <> | Date | Thu, 1 Dec 2022 12:31:18 +0200 | Subject | Re: [PATCH] habanalabs: fix double assignment in MMU V1 |
| |
On Tue, Nov 29, 2022 at 1:52 PM Marco Pagani <marpagan@redhat.com> wrote: > > Removing double assignment of the hop2_pte_addr > variable in dram_default_mapping_fini(). > > Dead store reported by clang-analyzer. > > Signed-off-by: Marco Pagani <marpagan@redhat.com> > --- > drivers/misc/habanalabs/common/mmu/mmu_v1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c > index 8a40de4a4761..d925dc4dd097 100644 > --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c > +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c > @@ -344,7 +344,6 @@ static void dram_default_mapping_fini(struct hl_ctx *ctx) > } > } > > - hop2_pte_addr = hop2_addr; > hop2_pte_addr = hop2_addr; > for (i = 0 ; i < num_of_hop3 ; i++) { > clear_pte(ctx, hop2_pte_addr); > -- > 2.38.1 >
Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Applied to -next. Thanks, Oded
| |