Messages in this thread | | | Date | Thu, 1 Dec 2022 10:27:26 +0100 | Subject | Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver | From | Krzysztof Kozlowski <> |
| |
On 01/12/2022 10:01, JiaJie Ho wrote:
>>> + >>> + enable-side-channel-mitigation: >>> + description: Enable side-channel-mitigation feature for AES module. >>> + Enabling this feature will affect the speed performance of >>> + crypto engine. >>> + type: boolean >> >> Why exactly this is a hardware (DT) property, not runtime? >> > > This is a hardware setting provided in StarFive crypto engine only. > The crypto API doesn't control this setting during runtime and leaving this always on will impact speed performance. > So, I added this property to allow user to control this in dtb.
Devicetree should not describe policies, so without justification it does not look like hardware property. Drop.
Best regards, Krzysztof
| |