Messages in this thread Patch in this message | | | Date | Thu, 1 Dec 2022 10:17:22 +0100 | From | Stefano Garzarella <> | Subject | Re: [RFC PATCH v2 1/6] vsock: return errors other than -ENOMEM to socket |
| |
On Fri, Nov 25, 2022 at 05:03:06PM +0000, Arseniy Krasnov wrote: >From: Bobby Eshleman <bobby.eshleman@bytedance.com> > >This removes behaviour, where error code returned from any >transport was always switched to ENOMEM. > >Signed-off-by: Bobby Eshleman <bobby.eshleman@bytedance.com> >Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> >--- > net/vmw_vsock/af_vsock.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
This patch LGTM, but I would move after the 2 patches that change vmci and hyperv transports.
First we should fix the transports by returning the error we think is right, and then expose it to the user.
Thanks, Stefano
> >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 884eca7f6743..61ddab664c33 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1862,8 +1862,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg, > written = transport->stream_enqueue(vsk, > msg, len - total_written); > } >+ > if (written < 0) { >- err = -ENOMEM; >+ err = written; > goto out_err; > } > >-- >2.25.1
| |