Messages in this thread | | | Date | Thu, 1 Dec 2022 20:32:57 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] error-injection: Add prompt for function error injection |
| |
On Fri, 2 Dec 2022 02:03:03 +0100 (CET) Jiri Kosina <jikos@kernel.org> wrote:
> On Thu, 1 Dec 2022, Linus Torvalds wrote: > > > > Anyway, I believe [1] that ERROR_INJECTION has been designed as a > > > debugging feature in the first place, and should stay so. After figuring > > > out now that HID-BPF actually has hard dependence on it, I fully agree [2] > > > that the series should be ditched for 6.2 and will work with Benjamin to > > > have it removed from current hid.git#for-next. > > > > I do think that it is interesting to have a "let's have a bpf > > insertion hook here", so I'm not against the _concept_ of HID doing > > that. > > Absolutely, me neither, quite the contrary -- I am quite happy to see > HID-BPF happening, because it'll actually make life easier for everybody: > for people with quirky hardware (trivial testing of fixes), for kernel > developers (trivial testing of fixes), and for distributions (trivial > distribution of fixes).
Full disclosure, I'm not against a bpf_hook either. In fact, I think I even stated something to that effect, like adding a bpf_hook annotation to functions or whatever, so that people can plainly see that the function can have bpf attached to it.
I just *hate* the ad hoc way of using infrastructure for other purposes than what they were designed for.
-- Steve
| |