Messages in this thread | | | Date | Thu, 1 Dec 2022 22:57:24 +0000 | From | Mark Brown <> | Subject | Re: [V3] spi: spi-geni-qcom: Add support for SE DMA mode |
| |
On Thu, Dec 01, 2022 at 02:40:32PM -0800, Doug Anderson wrote: > On Tue, Nov 29, 2022 at 1:23 AM Vijaya Krishna Nivarthi > > > > + if (mas->cur_xfer_mode == GENI_SE_DMA) { > > + if (m_cmd & SPI_RX_ONLY) { > > + ret = geni_se_rx_dma_prep(se, xfer->rx_buf, > > + xfer->len, &xfer->rx_dma);
> In response to v1 I asked if it's really OK to use "xfer->rx_dma" for > your purposes since it's supposed to be managed by the SPI framework.
> It still makes me nervous to use it, even though it seems to work. > Since we're using it in an undocumented way, I'd be nervous that the > SPI framework might change what it's doing and break us in the future.
I'm a bit nervous too - why exactly are we doing the open coding here? [unhandled content-type:application/pgp-signature] | |