Messages in this thread | | | Date | Wed, 9 Nov 2022 17:32:43 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH] KVM: svm/avic: Drop "struct kvm_x86_ops" for avic_hardware_setup() |
| |
+Maxim
On Wed, Nov 09, 2022, Like Xu wrote: > From: Like Xu <likexu@tencent.com> > > Even in commit 4bdec12aa8d6 ("KVM: SVM: Detect X2APIC virtualization > (x2AVIC) support"), where avic_hardware_setup() was first introduced, > its only pass-in parameter "struct kvm_x86_ops *ops" is not used at all.
I assume the intent was to fill the AVIC ops so that they don't need to be exposed outside of avic.c. I like the idea in theory, but unlike vmx_nested_ops they wouldn't be fully contained, which IMO would make the code as a whole more difficult to follow.
Maxim, any objection?
> Clean it up a bit to avoid compiler ranting from LLVM toolchain. > > Signed-off-by: Like Xu <likexu@tencent.com> > ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
| |