Messages in this thread | | | From | Avri Altman <> | Subject | RE: [RFC PATCH v1 0/2] UFS Advanced RPMB | Date | Wed, 9 Nov 2022 08:18:54 +0000 |
| |
> In UFS 4.0, it introduced advanced RPMB, which can significantly improve > RPMB's command performance, enhancing its atomic operation. We don't > know which implementation will please everyone, mark this advanced RPMB > patch as RFC. Any suggestions to make the patch a master patch are welcome. > > Based on suggestions and feedback from Hannes Reinecke and Bart, we can > use job_bsg->request and job_bsg->reply to pass EHS packets without changing > the BSG V4 structure and BSG core. So we push RFC patch just to start > Advanced RPMB mainlining I concur with this approach. The current limitations that the new spec imposes, e.g. putting confidential data in a construct that lives in the ufs-driver, practically gives no other alternative but ufs-bsg.
If no one else object, maybe you can leave out the rfc from the next version.
Thanks, Avri
> > Bean Huo (2): > ufs: core: Advanced RPMB detection > ufs: core: Add advanced RPMB support in ufs_bsg > > drivers/ufs/core/ufs_bsg.c | 115 +++++++++++++--------- > drivers/ufs/core/ufshcd.c | 161 ++++++++++++++++++++++++------- > include/uapi/scsi/scsi_bsg_ufs.h | 30 +++++- > include/ufs/ufs.h | 3 + > include/ufs/ufshcd.h | 5 + > 5 files changed, 233 insertions(+), 81 deletions(-) > > -- > 2.25.1
| |