Messages in this thread | | | Date | Tue, 8 Nov 2022 13:13:28 +0100 | Subject | Re: [PATCH v3 4/5] dt-bindings: soc: qcom: convert non-smd RPM bindings to dt-schema | From | Neil Armstrong <> |
| |
Hi,
On 06/11/2022 04:48, Bjorn Andersson wrote: > On Fri, Oct 21, 2022 at 05:27:56PM +0200, Neil Armstrong wrote: > [..] >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml >> new file mode 100644 >> index 000000000000..6531c8805894 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml >> @@ -0,0 +1,101 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ipc-rpm.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Qualcomm Resource Power Manager (RPM) over IPC > > It's true that there's something executing elsewhere in the SoC > acting upon the request written to the RPM memory region. > > But for me the phrasing "over IPC" applies much more to the SMD/GLINK > variant than to this. So I would prefer to just name this > "qcom,rpm.yaml" and omit the "over IPC" phrasing. > > > Binding looks good to me.
Thanks I'll post a v4 with these changes, Rob, Lee, can I keep your current review tags with only the renaming and removal of " over IPC" in title ?
> > Thanks, > Bjorn
Thanks, Neil
| |