Messages in this thread | | | Date | Tue, 8 Nov 2022 11:40:18 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH 08/14] net: vlan: remove invalid VLAN protocol warning |
| |
On Tue, Nov 08, 2022 at 10:20:44AM +0100, Felix Fietkau wrote: > I need to look into how METADATA_HW_PORT_MUX works, but I think it could > work.
Could you please coordinate with Maxime to come up with something common? Currently he proposes a generic "oob" tagger, while you propose that we stay with the "mtk"/"qca" taggers, but they are taught to look after offloaded metadata rather than in the packet. IMO your proposal sounds better; the name of the tagging protocol is already exposed to user space via /sys/class/net/<dsa-master>/dsa/tagging and therefore ABI. It's just that we need a way to figure out how to make the flow dissector and other layers not adjust for DSA header length if the DSA tag is offloaded and not present in the packet.
| |