Messages in this thread | | | From | Avri Altman <> | Subject | RE: [RFC PATCH v1 2/2] ufs: core: Add advanced RPMB support in ufs_bsg | Date | Tue, 8 Nov 2022 21:17:28 +0000 |
| |
> > no, I didn't wrap RPMB packet in query-request/response, it is > > inupiu_req and upiu_rsp, it is upiu command. > I was thinking you are using a query request upiu because you are using > device management commands flow, And specifically, I didn't see where you > are setting ucd_req_ptr->sc.cdb, Which should hold the security protocol > cdb. Ahha, ok. I see this now - you are just copying the prepared req_upiu as a whole. And I guess that this req_upiu indeed contains the security protocol cdb, etc. Ok then. So please ignore all the above. let me review this patch from scratch.
Thanks, Avri
| |