Messages in this thread | | | Date | Mon, 7 Nov 2022 18:22:52 +0100 | Subject | Re: [PATCH 2/8] KVM: SVM: replace regs argument of __svm_vcpu_run with vcpu_svm | From | Paolo Bonzini <> |
| |
On 11/7/22 18:10, Sean Christopherson wrote: > Needs to include asm/asm-offsets.h, otherwise the compiler may think that > SVM_vcpu_arch_regs is a symbol. > > ERROR: modpost: "SVM_vcpu_arch_regs" [arch/x86/kvm/kvm-amd.ko] undefined! > > diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S > index 8fac744361e5..8d0b0781462e 100644 > --- a/arch/x86/kvm/svm/vmenter.S > +++ b/arch/x86/kvm/svm/vmenter.S > @@ -1,6 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #include <linux/linkage.h> > #include <asm/asm.h> > +#include <asm/asm-offsets.h> > #include <asm/bitsperlong.h> > #include <asm/kvm_vcpu_regs.h> > #include <asm/nospec-branch.h>
Yeah, it's included slightly later (I did test each patch independently, but I'm not sure how it ended up disappearing from this one).
Paolo
| |