lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RFC 18/19] RDMA/hw/qib/qib_user_pages: remove FOLL_FORCE usage
    Date
    FOLL_FORCE is really only for debugger access. As we unpin the pinned pages
    using unpin_user_pages_dirty_lock(true), the assumption is that all these
    pages are writable.

    FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove
    it.

    Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: David Hildenbrand <david@redhat.com>
    ---
    drivers/infiniband/hw/qib/qib_user_pages.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c b/drivers/infiniband/hw/qib/qib_user_pages.c
    index f4b5f05058e4..f693bc753b6b 100644
    --- a/drivers/infiniband/hw/qib/qib_user_pages.c
    +++ b/drivers/infiniband/hw/qib/qib_user_pages.c
    @@ -110,7 +110,7 @@ int qib_get_user_pages(unsigned long start_page, size_t num_pages,
    for (got = 0; got < num_pages; got += ret) {
    ret = pin_user_pages(start_page + got * PAGE_SIZE,
    num_pages - got,
    - FOLL_LONGTERM | FOLL_WRITE | FOLL_FORCE,
    + FOLL_LONGTERM | FOLL_WRITE,
    p + got, NULL);
    if (ret < 0) {
    mmap_read_unlock(current->mm);
    --
    2.38.1
    \
     
     \ /
      Last update: 2022-11-07 17:22    [W:2.662 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site