lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage
    Date
    FOLL_FORCE is really only for debugger access. According to commit
    707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always
    writable"), the pinned pages are always writable.

    FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove
    it.

    Cc: Tomasz Figa <tfiga@chromium.org>
    Cc: Marek Szyprowski <m.szyprowski@samsung.com>
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: David Hildenbrand <david@redhat.com>
    ---
    drivers/media/common/videobuf2/frame_vector.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c
    index 542dde9d2609..062e98148c53 100644
    --- a/drivers/media/common/videobuf2/frame_vector.c
    +++ b/drivers/media/common/videobuf2/frame_vector.c
    @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames,
    start = untagged_addr(start);

    ret = pin_user_pages_fast(start, nr_frames,
    - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
    + FOLL_WRITE | FOLL_LONGTERM,
    (struct page **)(vec->ptrs));
    if (ret > 0) {
    vec->got_ref = true;
    --
    2.38.1
    \
     
     \ /
      Last update: 2022-11-07 17:22    [W:2.745 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site