lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v2 01/13] x86/microcode/intel: Prevent printing updated microcode rev multiple times
On Sun, Nov 06, 2022 at 02:35:58PM +0100, Borislav Petkov wrote:
> On Thu, Nov 03, 2022 at 05:58:49PM +0000, Ashok Raj wrote:
> > @@ -696,8 +697,7 @@ static int collect_cpu_info(int cpu_num, struct cpu_signature *csig)
> >
> > csig->rev = c->microcode;
> >
> > - /* No extra locking on prev, races are harmless. */
> > - if (csig->sig != prev.sig || csig->pf != prev.pf || csig->rev != prev.rev) {
> > + if (bsp && csig->rev != prev.rev) {
> > pr_info("sig=0x%x, pf=0x%x, revision=0x%x\n",
> > csig->sig, csig->pf, csig->rev);
>
> And now that we've established that we don't do mixed steppings anymore
> and the microcode revision is the same system-wide, you should simply
> drop this pr_info(), in your next patch you're adding
>
> +static u32 early_old_rev;
>
> That thing should simply be
>
> /* Currently applied microcode revision */
> static u32 microcode_rev;
>
> and you simply update that one each time you update microcode and print
> it as the previous and the new one and then write the new one into this
> var and that's it. Simple.
>

I removed that preparing for the next round. We already have late-loading
capture the previous rev already. So we don't need any new changes.

[ 482.242727] microcode: Reload completed, microcode revision: 0x2b000070 -> 0x2b000081

Only missing is the ucode date, not a big deal missing it.

\
 
 \ /
  Last update: 2022-11-07 17:14    [W:0.135 / U:2.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site