lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [External] [PATCH 1/2] erofs: put metabuf in error path in fscache mode
From


在 2022/11/4 13:40, Jingbo Xu 写道:
> For tail packing layout, put metabuf when error is encountered.
>
> Fixes: 1ae9470c3e14 ("erofs: clean up .read_folio() and .readahead() in fscache mode")
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>
> ---
> fs/erofs/fscache.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index fe05bc51f9f2..83559008bfa8 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -287,8 +287,10 @@ static int erofs_fscache_data_read(struct address_space *mapping,
> return PTR_ERR(src);
>
> iov_iter_xarray(&iter, READ, &mapping->i_pages, pos, PAGE_SIZE);
> - if (copy_to_iter(src + offset, size, &iter) != size)
> + if (copy_to_iter(src + offset, size, &iter) != size) {
> + erofs_put_metabuf(&buf);
> return -EFAULT;
> + }
> iov_iter_zero(PAGE_SIZE - size, &iter);
> erofs_put_metabuf(&buf);
> return PAGE_SIZE;

\
 
 \ /
  Last update: 2022-11-07 15:42    [W:0.062 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site