lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
Date


> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 07 November 2022 14:42
> To: chanho61.park@samsung.com; Inbaraj E <inbaraj.e@samsung.com>;
> Sylwester Nawrocki <s.nawrocki@samsung.com>; tomasz.figa@gmail.com;
> Chanwoo Choi <cw00.choi@samsung.com>; ALIM AKHTAR
> <alim.akhtar@samsung.com>; mturquette@baylibre.com;
> sboyd@kernel.org; robh+dt@kernel.org
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey@samsung.com>
> Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
> CMU_FSYS1 mmc card clock
>
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller@17040000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is "gout"? "dout" had a meaning as clock divider output.
> >
> > "gout" is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
>
> OK, then this should be in commit msg.
>
> My question about full legal name remains, as here in replies I see "Inbaraj
> E".
>

I have address your review comment, and posted v2.
Thanks for review.

> Best regards,
> Krzysztof


\
 
 \ /
  Last update: 2022-11-07 15:29    [W:0.044 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site