Messages in this thread | | | Date | Mon, 7 Nov 2022 09:10:36 -0400 | From | Jason Gunthorpe <> | Subject | Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major |
| |
On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > I don't agree with your statement that it should be "a layer over top of DRM". > Anything on top of DRM is a device driver. > Accel is not a device driver, it is a new type of drm minor / drm driver.
Yeah, I still think this is not the right way, you are getting almost nothing from DRM and making everything more complicated in the process.
> The only alternative imo to that is to abandon the idea of reusing > drm, and just make an independant accel core code.
Not quite really, layer it properly and librarize parts of DRM into things accel can re-use so they are not intimately tied to the DRM struct device notion.
IMHO this is much better, because accel has very little need of DRM to manage a struct device/cdev in the first place.
Jason
| |