Messages in this thread | | | Date | Mon, 7 Nov 2022 08:42:43 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr |
| |
On Mon, Nov 07, 2022 at 11:31:09AM +0800, Qi Zheng wrote:
> @@ -31,9 +33,9 @@ bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags) > return false; > > if (gfpflags & __GFP_NOWARN) > - failslab.attr.no_warn = true; > + flags |= FAULT_NOWARN;
You should add a comment here about why this is required, to avoid deadlocking printk
Jason
| |