lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe:Re: Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs
















At 2022-11-07 17:53:57, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>On Mon, Nov 07, 2022 at 05:30:56PM +0800, Slark Xiao wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> At 2022-11-07 17:02:29, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>> >On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote:
>> >> To make code neat and for convenience purpose, use macro for
>> >> some VIDs. These macros are supposed to be added to pci_ids.h.
>> >
>> >No, they are not supposed to be added there at all.
>> >
>> >And they are not a "macro", it is a "#define".
>> >
>> >> But until the macros are used in multiple places, it is not
>> >> recommended. So adding it locally for now.
>> >
>> >Again, these are not macros
>> >
>> >thanks,
>> >
>> >greg k-h
>>
>> Hi Greg,
>> Thanks for your comment.
>> In my opinion, MACRO almost same as a '#define'. May I know how do
>> you call such definition?
>
>As I said, this is just a define, not a macro at all.
>
>> And could you give your comments in previous patch, not the 'final' one?
>
>I do not understand, what previous patrch? What "final" one? What is
>the "latest" patch?
previous patch:
https://lore.kernel.org/lkml/20221027115123.5326-1-slark_xiao@163.com/
https://lore.kernel.org/lkml/20221028023711.4196-1-slark_xiao@163.com/
https://lore.kernel.org/lkml/20221102024437.15248-1-slark_xiao@163.com/

'final' patch:
https://lore.kernel.org/lkml/20221107084826.8888-1-slark_xiao@163.com/
https://lore.kernel.org/lkml/20221101015858.6777-1-slark_xiao@163.com/

The 'final' patch was committed according to the advice of the feature
maintainer.
>
>> In another pci_ids patch, you break it in v3 and break it here again in v2.
>
>I broke what?
You could have voiced out such comment in V1, V2 before the 'final'.
>
>> Honestly, it's positive for whole project. But it's negative for contributor
>> and maintainer.
>
>I am totally confused here and do not understand what you are referring
>to, sorry.
>
>greg k-h
\
 
 \ /
  Last update: 2022-11-07 11:27    [W:0.049 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site