lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: rzn1: Check return value in rzn1_rtc_probe
Hello,

zys.zljxml@gmail.com wrote on Mon, 7 Nov 2022 17:25:44 +0800:

> From: Yushan Zhou <katrinzhou@tencent.com>
>
> The rzn1_rtc_probe() function utilizes devm_pm_runtime_enable()
> but wasn't checking the return value. Fix it by adding missing
> check.
>
> Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
>
> Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
> ---
> drivers/rtc/rtc-rzn1.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> index ac788799c8e3..0d36bc50197c 100644
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
> @@ -355,7 +355,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
> set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
> clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
>
> - devm_pm_runtime_enable(&pdev->dev);
> + ret = devm_pm_runtime_enable(&pdev->dev);
> + if (ret < 0)
> + return ret;
> ret = pm_runtime_resume_and_get(&pdev->dev);
> if (ret < 0)
> return ret;

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

\
 
 \ /
  Last update: 2022-11-07 10:50    [W:0.048 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site