lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next v2] crypto: rockchip: Remove surplus dev_err() when using platform_get_irq()
Le Fri, Nov 04, 2022 at 03:45:27PM +0800, Yang Li a écrit :
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is
> redundant because platform_get_irq() already prints an error
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>
> change in v2:
> --According to Corentin's suggestion, make the subject started by "crypto: rockchip:".
>
> drivers/crypto/rockchip/rk3288_crypto.c | 1 -
> 1 file changed, 1 deletion(-)
>

Hello

Acked-by: Corentin Labbe <clabbe@baylibre.com>

Thanks

\
 
 \ /
  Last update: 2022-11-07 10:25    [W:0.038 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site