lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] mtd: onenand: omap2: add dependency on GPMC
From


On 07/11/2022 11:15, Krzysztof Kozlowski wrote:
> OMAP2 OneNAND driver uses gpmc_omap_onenand_set_timings() provided by
> OMAP_GPMC driver, so the latter cannot be module if OneNAND driver is
> built-in:
>
> /usr/bin/arm-linux-gnueabi-ld: drivers/mtd/nand/onenand/onenand_omap2.o: in function `omap2_onenand_probe':
> onenand_omap2.c:(.text+0x520): undefined reference to `gpmc_omap_onenand_set_timings'
>
> The OMAP_GPMC is also a runtime dependency.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 854fd9209b20 ("memory: omap-gpmc: Allow building as a module")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

>
> ---
>
> Changes since v1:
> 1. Always require OMAP_GPMC (drop !OMAP_GPMC).
> 2. Adjust commit msg.
> ---
> drivers/mtd/nand/onenand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/onenand/Kconfig b/drivers/mtd/nand/onenand/Kconfig
> index 34d9a7a82ad4..c94bf483541e 100644
> --- a/drivers/mtd/nand/onenand/Kconfig
> +++ b/drivers/mtd/nand/onenand/Kconfig
> @@ -26,6 +26,7 @@ config MTD_ONENAND_OMAP2
> tristate "OneNAND on OMAP2/OMAP3 support"
> depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM)
> depends on OF || COMPILE_TEST
> + depends on OMAP_GPMC
> help
> Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
> via the GPMC memory controller.

--
cheers,
-roger

\
 
 \ /
  Last update: 2022-11-07 10:19    [W:0.107 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site