| Date | Mon, 7 Nov 2022 11:16:10 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v4a 02/38] ARM: spear: Do not use timer namespace for timer_shutdown() function |
| |
On 05-11-22, 07:05, Guenter Roeck wrote: > On Sat, Nov 05, 2022 at 02:00:26AM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > > > A new "shutdown" timer state is being added to the generic timer code. One > > of the functions to change the timer into the state is called > > "timer_shutdown()". This means that there can not be other functions > > called "timer_shutdown()" as the timer code owns the "timer_*" name space. > > > > Rename timer_shutdown() to evt_timer_shutdown() to avoid this conflict. > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com> > > Cc: Russell King <linux@armlinux.org.uk> > > Cc: soc@kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> > > Nitpick: I would have called it spear_timer_shutdown(). POV, so
+1
Other than that:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
|