lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 8/8] arm64: dts: qcom: sm4250: Add support for oneplus-billie2
From


On 11/4/22 21:17, Krzysztof Kozlowski wrote:
> On 30/10/2022 05:42, Iskren Chernev wrote:
>> Add initial support for OnePlus Nord N100, based on SM4250. Currently
>> working:
>> - boots
>> - usb
>> - built-in flash storage (UFS)
>> - SD card reader
>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 241 ++++++++++++++++++
>> 2 files changed, 242 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index b0558d3389e5..eb2a58b8af5f 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-polaris.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
>> new file mode 100644
>> index 000000000000..a3f1c7c41fd7
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts
>> @@ -0,0 +1,241 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
>> +/*
>> + * Copyright (c) 2021, Iskren Chernev <iskren.chernev@gmail.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "sm4250.dtsi"
>> +
>> +/ {
>> + model = "OnePlus Nord N100";
>> + compatible = "oneplus,billie2", "qcom,sm4250";
>> +
>> + /* required for bootloader to select correct board */
>> + qcom,msm-id = <0x1a1 0x10000 0x1bc 0x10000>;
>> + qcom,board-id = <0x1000b 0x00>;
>
> These are currently not allowed for SM4250. If there are really needed,
> please justify it and update
> Documentation/devicetree/bindings/arm/qcom.yaml. Then also update
> include/dt-bindings/arm/qcom,ids.h and socinfo driver.

I'm having some trouble with testing this ATM. If this is the only patch
with remaining complaints, the rest can be merged (because there is other
work prepped for 4250/6115 that depends on it), and once billie2 is figured
out it could be merged separately.

> Best regards,
> Krzysztof

Regards,
Iskren

\
 
 \ /
  Last update: 2022-11-07 10:02    [W:0.051 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site