Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 7 Nov 2022 17:22:47 -0800 | Subject | Re: [PATCH v2 1/2] arm64: dts: qcom: Fully describe fingerprint node on Herobrine |
| |
Hi,
On Mon, Nov 7, 2022 at 11:15 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Update the fingerprint node on Herobrine to match the fingerprint DT > binding. This will allow us to drive the reset and boot gpios from the > driver when it is re-attached after flashing. We'll also be able to boot > the fingerprint processor if the BIOS isn't doing it for us. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)
From Bjorn's recent comment [1], I think your subject needs modification to:
arm64: dts: qcom: sc7280: Fully describe fingerprint node on Herobrine
Other than that this seems fine and is a better description of hardware, so:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I guess we're still leaving gpio77 alone (AKA not describing it in the fingerprint regulator)?
[1] https://lore.kernel.org/r/20221017224853.stuy5qeqxjxntob4@builder.lan/
| |