Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 7 Nov 2022 16:24:06 -0800 | Subject | Re: [PATCH v2 13/18] arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180 |
| |
Hi,
On Mon, Nov 7, 2022 at 3:57 PM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > Add silicon specific compatible qcom,mdss-dsi-ctrl-sc7180 to the > mdss-dsi-ctrl block. This allows us to differentiate the specific bindings > for sc7180 against the yaml documentation. > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Rajendra Nayak <rnayak@codeaurora.org> > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index d2c374e9d8c03..07acb7f843d62 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2985,7 +2985,8 @@ opp-460000000 { > }; > > dsi0: dsi@ae94000 { > - compatible = "qcom,mdss-dsi-ctrl"; > + compatible = "qcom,mdss-dsi-ctrl-sc7180", > + "qcom,mdss-dsi-ctrl";
This seems fine, but I don't think it matches your bindings. Your bindings says you can have one compatible string. It could be "qcom,mdss-dsi-ctrl-sc7180" or it could be "qcom,mdss-dsi-ctrl". ...but your device tree has two compatible strings: the SoC specific one and the fallback one. You need to change your bindings to make this work.
-Doug
| |