Messages in this thread | | | Date | Mon, 7 Nov 2022 23:21:24 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 4/5] rtc: rtc-cmos: Rename ACPI-related functions |
| |
On Mon, Nov 07, 2022 at 09:01:50PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The names of rtc_wake_setup() and cmos_wake_setup() don't indicate > that these functions are ACPI-related, which is the case, and the > former doesn't really reflect the role of the function. > > Rename them to acpi_rtc_event_setup() and cmos_acpi_wake_setup(), > respectively, to address this shortcoming.
Hmm... I'm not sure I understand why in one case acpi is a prefix and in the other is kinda mid-suffix?
-- With Best Regards, Andy Shevchenko
| |