lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints
    Date
    In accordance with the way the device DT-node is actually defined in
    arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed
    by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the
    DT-bindings lack. Let's extend the interrupts property constraints then
    and fix the schema example so one would be acceptable by the actual device
    DT-bindings.

    Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller")
    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Acked-by: Rob Herring <robh@kernel.org>
    Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

    ---

    Changelog v5:
    - This is a new patch added on the v5 release of the patchset.
    ---
    .../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
    index 48ed227fc5b9..53da2edd7c9a 100644
    --- a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
    +++ b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
    @@ -36,7 +36,7 @@ properties:
    - const: mpu

    interrupts:
    - maxItems: 1
    + maxItems: 2

    clocks:
    items:
    @@ -94,8 +94,9 @@ examples:
    #interrupt-cells = <1>;
    ranges = <0x81000000 0 0x40000000 0 0x40000000 0 0x00010000>,
    <0x82000000 0 0x50000000 0 0x50000000 0 0x20000000>;
    - interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
    - interrupt-names = "intr";
    + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>,
    + <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
    + interrupt-names = "msi", "intr";
    interrupt-map-mask = <0 0 0 7>;
    interrupt-map =
    <0 0 0 1 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
    --
    2.38.0

    \
     
     \ /
      Last update: 2022-11-07 22:13    [W:4.105 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site