lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 09/24] dmaengine: dw-edma: Drop chancnt initialization
    Date
    DMA device drivers aren't supposed to initialize the dma_device.chancnt
    field. It will be done by the DMA-engine core in accordance with number of
    added virtual DMA-channels. Pre-initializing it with some value causes
    having a wrong number of channels printed in the device summary.

    Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Acked-by: Vinod Koul <vkoul@kernel.org>
    ---
    drivers/dma/dw-edma/dw-edma-core.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
    index 6c9f95a8e397..ecd3e8f7ac5d 100644
    --- a/drivers/dma/dw-edma/dw-edma-core.c
    +++ b/drivers/dma/dw-edma/dw-edma-core.c
    @@ -817,7 +817,6 @@ static int dw_edma_channel_setup(struct dw_edma *dw, bool write,
    dma->src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
    dma->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
    dma->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
    - dma->chancnt = cnt;

    /* Set DMA channel callbacks */
    dma->dev = chip->dev;
    --
    2.38.0

    \
     
     \ /
      Last update: 2022-11-07 22:06    [W:3.197 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site