Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 7 Nov 2022 10:15:21 -0800 | Subject | Re: [PATCH v11 4/5] arm64: dts: qcom: sc7280: add sc7280-herobrine-audio-rt5682-3mic3.dtsi for evoker |
| |
Hi,
On Mon, Nov 7, 2022 at 1:45 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > +&lpass_va_macro { > + vdd-micb-supply = <&pp1800_l2c>; > + pinctrl-0 = <&lpass_dmic01_clk>, <&lpass_dmic01_data>, <&lpass_dmic23_clk>, > + <&lpass_dmic23_data>; > + > + status = "okay"; > +}; > + > +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */ > + > +&lpass_dmic01_clk { > + drive-strength = <8>; > + bias-disable; > +}; > + > +&lpass_dmic01_clk_sleep { > + drive-strength = <2>; > +};
All of these "sleep" pinctrl states don't actually do anything useful because (currently) nobody refers to them. Off-list I've asked Srinivasa (now CCed here) to address this and I think it's fine for you to have them here for now and then we can use or remove them all at once.
In any case, this patch looks good to me now, thanks!
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |