lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote:
> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index be1b5746eddb..5352181aa393 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -38,6 +38,7 @@ properties:
> - qcom,scm-msm8994
> - qcom,scm-msm8996
> - qcom,scm-msm8998
> + - qcom,scm-qdu1000
> - qcom,scm-sc7180
> - qcom,scm-sc7280
> - qcom,scm-sc8280xp
> @@ -81,6 +82,20 @@ properties:
> description: TCSR hardware block
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,scm-qdu1000
> + then:
> + properties:
> + '#reset-cells':
> + maxItems: 1
> + clocks: false
> + clock-names: false
> +
> + required:
> + - '#reset-cells'

Please document what this reset is expected to be wired to, and write a
sentence or two in the commit message how the QDU differs from existing
platforms supported by the binding.

Thanks,
Bjorn

> - if:
> properties:
> compatible:
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2022-11-07 18:39    [W:0.098 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site