Messages in this thread | | | Subject | Re: [PATCH bpf-next] selftests/bpf: fix build-id for liburandom_read.so | From | Daniel Borkmann <> | Date | Fri, 4 Nov 2022 18:38:22 +0100 |
| |
Hi Artem,
On 11/4/22 2:29 PM, KP Singh wrote: > On Fri, Nov 4, 2022 at 10:41 AM Artem Savkov <asavkov@redhat.com> wrote: >> >> lld produces "fast" style build-ids by default, which is inconsistent >> with ld's "sha1" style. Explicitly specify build-id style to be "sha1" >> when linking liburandom_read.so the same way it is already done for >> urandom_read. >> >> Signed-off-by: Artem Savkov <asavkov@redhat.com> > > Acked-by: KP Singh <kpsingh@kernel.org> > > This was done in > https://lore.kernel.org/bpf/20200922232140.1994390-1-morbo@google.com
When you say "fix", does it actually fix a failing test case or is it more of a cleanup to align liburandom_read build with urandom_read? From glancing at the code, we only check build id for urandom_read.
Cheers, Daniel
| |