Messages in this thread | | | Date | Fri, 4 Nov 2022 15:04:49 +0100 | Subject | Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC | From | jerome Neanne <> |
| |
On 04/11/2022 14:56, Lee Jones wrote: > On Fri, 04 Nov 2022, jerome Neanne wrote: > >> >> >> On 31/10/2022 12:00, Lee Jones wrote: >>>> diff --git a/include/linux/mfd/tps65219.h b/include/linux/mfd/tps65219.h >>>> new file mode 100644 >>>> index 000000000000..2c1cf92e92ac >>>> --- /dev/null >>>> +++ b/include/linux/mfd/tps65219.h >> >>>> +/** >>>> + * struct tps65219 - tps65219 sub-driver chip access routines >>>> + * >>>> + * Device data may be used to access the TPS65219 chip >>>> + * >>>> + * @dev MFD device >>>> + * @regmap Regmap for accessing the device registers >>>> + * @irq_data Regmap irq data used for the irq chip >>>> + * @nb notifier block for the restart handler >>>> + */ >>> >>> This header needs work. >> I'm not sure to get your point here. Just something like below to match >> format or do you expect more: >> >> /** >> * struct tps65219 - tps65219 sub-driver chip access routines >> * >> * Device data may be used to access the TPS65219 chip >> * >> * @dev: MFD device >> * @regmap: Regmap for accessing the device registers >> * @irq_data: Regmap irq data used for the irq chip >> * @nb: notifier block for the restart handler >> */ >> >>> >>> Can you try an compile with W=1 please. >> This raise one warning on mfd: > > Is that before or after the header was fixed-up? After the header was fixed-up. > >> drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but >> not used [-Wunused-function] >> 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) >> | ^~~~~~~~~~~~~~~~~~~~~~ >> soft_shutdown has been validated and is used in TI baseline even if not >> hooked in upstream version further to this review: >> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ > > Will tps65219_soft_shutdown() be used? > > I think it should be removed until it's utilised in Mainline. > I'll remove then
Thanks for your feedback
| |