lkml.org 
[lkml]   [2022]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND v2 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding

On Fri, 28 Oct 2022 18:04:33 +0200, Johan Hovold wrote:
> The current QMP USB PHY bindings are based on the original MSM8996 PCIe
> PHY binding which provided multiple PHYs per IP block and these in turn
> were described by child nodes.
>
> The QMP USB PHY block only provide a single PHY and the remnant child
> node does not really reflect the hardware.
>
> The original MSM8996 binding also ended up describing the individual
> register blocks as belonging to either the wrapper node or the PHY child
> nodes.
>
> This is an unnecessary level of detail which has lead to problems when
> later IP blocks using different register layouts have been forced to fit
> the original mould rather than updating the binding. The bindings are
> arguable also incomplete as they only the describe register blocks used
> by the current Linux drivers (e.g. does not include the per lane PCS
> registers).
>
> Note that PCS_USB region is also not described by the current bindings
> despite being used by the driver and this has led to people increasing
> the size of the PCS region in the devicetree so that it includes PCS_USB
> registers even though other regions like TX and RX may lie in between.
>
> Add a new binding for the QMP USB PHYs found on SC8280XP which further
> bindings can be based on.
>
> Note that this also fixes the SC8280XP "phy_phy" reset name.
>
> Also note that the current binding is simply removed instead of being
> deprecated as it was only recently merged and support for SC8280XP is
> still under development. And, specifically, there is no support in
> mainline for the multiport controller that uses these PHYs.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../phy/qcom,msm8996-qmp-usb3-phy.yaml | 13 ---
> .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 105 ++++++++++++++++++
> 2 files changed, 105 insertions(+), 13 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
>

Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2022-11-04 22:41    [W:2.023 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site