| Subject | Re: [PATCH v2 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy | From | James Bottomley <> | Date | Fri, 04 Nov 2022 15:57:20 -0400 |
| |
On Wed, 2022-11-02 at 00:06 +0100, Ahelenia Ziemiańska wrote: [...] > @@ -4356,7 +4347,7 @@ static int ncr_queue_command (struct ncb *np, > struct scsi_cmnd *cmd) > */ > > /* activate this job. */ > - cp->magic = CCB_MAGIC; > + cp->busy = true; > > /* > ** insert next CCBs into start queue.
Are you sure this is just an internal magic number? The way these old scripts engines used to work is that the CCB array forms a mailbox and the card continually scans the mailbox to see if it has any work to do. These magic values are often a signal to the card that the CCB array contains a valid entry it hasn't seen and it should work on it, so the card might be expecting to see this full 32 bit value.
Regards,
James
[unhandled content-type:application/pgp-signature] |