Messages in this thread | | | From | Namhyung Kim <> | Date | Wed, 30 Nov 2022 10:31:10 -0800 | Subject | Re: [PATCH 1/2] perf tests: Fix "perf stat JSON output linter" test for new output |
| |
Hi,
On Wed, Nov 30, 2022 at 10:19 AM Ian Rogers <irogers@google.com> wrote: > > On Wed, Nov 30, 2022 at 3:15 AM James Clark <james.clark@arm.com> wrote: > > > > Commit c4b41b83c250 ("perf stat: Rename "aggregate-number" to > > "cpu-count" in JSON") renamed a field, so update the tests to reflect > > this. > > > > This fixes the following failure: > > > > $ sudo ./perf test "json output" -vvv > > 96: perf stat JSON output linter : > > --- start --- > > test child forked, pid 327720 > > Checking json output: no args [Success] > > Checking json output: system wide [Success] > > Checking json output: interval [Success] > > Checking json output: event [Success] > > Checking json output: per thread [Success] > > Checking json output: per node Test failed for input: > > ... > > Traceback (most recent call last): > > File "./tools/perf/tests/shell/lib/perf_json_output_lint.py", line 93, in <module> > > check_json_output(expected_items) > > File "./tools/perf/tests/shell/lib/perf_json_output_lint.py", line 78, in check_json_output > > raise RuntimeError(f'Unexpected key: key={key} value={value}') > > RuntimeError: Unexpected key: key=cpu-count value=16 > > test child finished with -1 > > ---- end ---- > > perf stat JSON output linter: FAILED! > > > > Fixes: c4b41b83c250 ("perf stat: Rename "aggregate-number" to "cpu-count" in JSON") > > Signed-off-by: James Clark <james.clark@arm.com> > > Namhyung mentioned reverting change c4b41b83c250, in which case > merging this would break the test again. I think the revert is better.
Yep, I will send the revert soon.
Thanks, Namhyung
| |