lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops
On Wed, Nov 30, 2022 at 05:07:46PM +0000, Matthias Kaehlcke wrote:
> On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:

> > Add __maybe_unused tag for system PM ops suspend and resume.
> > This is required to fix allmodconfig compilation issue.
> > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")

> This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add
> system suspend/resume PM ops")'. I see you fixed that in v2, but this patch
> has already been applied ...

with the fixes tag already updated as I was applying it.

> Mark, I appreciate you being responsive and picking patches quickly, it might
> help though to leave 'external' reviewers at least some time to provide their
> feedback :)

There's a balance with hanging on for utterly trivial patches to get
reviewed, especially in areas where reviews aren't relaible or
consistent.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-11-30 18:19    [W:0.082 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site