lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
    On Wed, Nov 30, 2022 at 03:57:35PM +0000, Jerry.Ray@microchip.com wrote:
    > >> static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
    > >> uint64_t *data)
    > >> {
    > >> struct lan9303 *chip = ds->priv;
    > >> - unsigned int u;
    > >> + unsigned int i, u;
    > >>
    > >> for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
    > >> u32 reg;
    > >> int ret;
    > >>
    > >> - ret = lan9303_read_switch_port(
    > >> - chip, port, lan9303_mib[u].offset, &reg);
    > >> -
    > >> + /* Read Port-based MIB stats. */
    > >> + ret = lan9303_read_switch_port(chip, port,
    > >> + lan9303_mib[u].offset,
    > >> + &reg);
    > >
    > >Speaking of unrelated changes...
    > >
    >
    > Cleaning up a warning generated from checkpatch

    Cleanups a good, but please put them in a patch of their own.

    https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#separate-your-changes

    3) Separate your changes

    Separate each logical change into a separate patch.

    Andrew

    \
     
     \ /
      Last update: 2022-11-30 17:01    [W:4.137 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site