Messages in this thread | | | Date | Wed, 30 Nov 2022 17:00:41 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats |
| |
On Wed, Nov 30, 2022 at 03:57:35PM +0000, Jerry.Ray@microchip.com wrote: > >> static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port, > >> uint64_t *data) > >> { > >> struct lan9303 *chip = ds->priv; > >> - unsigned int u; > >> + unsigned int i, u; > >> > >> for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) { > >> u32 reg; > >> int ret; > >> > >> - ret = lan9303_read_switch_port( > >> - chip, port, lan9303_mib[u].offset, ®); > >> - > >> + /* Read Port-based MIB stats. */ > >> + ret = lan9303_read_switch_port(chip, port, > >> + lan9303_mib[u].offset, > >> + ®); > > > >Speaking of unrelated changes... > > > > Cleaning up a warning generated from checkpatch
Cleanups a good, but please put them in a patch of their own.
https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#separate-your-changes
3) Separate your changes
Separate each logical change into a separate patch.
Andrew
| |