Messages in this thread | | | Date | Wed, 30 Nov 2022 07:55:46 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write() |
| |
On Wed, Nov 30, 2022 at 07:54:59AM -0800, Christoph Hellwig wrote: > > + ret = nbytes; > > ret is an int which bytes is a size_t. So we at least need a ssize_t > instead for ret, and even that assumes nbytes never overflows a ssize_t.
A better way might be to initialize ret to 0 at declaration time and then do
if (ret) return ret; return nbytes;
| |