lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write()
On Wed, Nov 30, 2022 at 07:54:59AM -0800, Christoph Hellwig wrote:
> > + ret = nbytes;
>
> ret is an int which bytes is a size_t. So we at least need a ssize_t
> instead for ret, and even that assumes nbytes never overflows a ssize_t.

A better way might be to initialize ret to 0 at declaration time and
then do

if (ret)
return ret;
return nbytes;

\
 
 \ /
  Last update: 2022-11-30 16:57    [W:0.053 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site