Messages in this thread | | | Date | Wed, 30 Nov 2022 16:42:33 +0100 | Subject | Re: [PATCH] arm64: dts: qcom: sa8540p-ride: enable PCIe support | From | Krzysztof Kozlowski <> |
| |
On 30/11/2022 16:37, Brian Masney wrote: > Add the vreg_l11a, pcie3a, pcie3a_phy, and tlmm nodes that are necessary > in order to get PCIe working on the QDrive3.
Thank you for your patch. There is something to discuss/improve.
> +&pcie3a_phy { > + vdda-phy-supply = <&vreg_l11a>; > + vdda-pll-supply = <&vreg_l3a>; > + > + status = "okay"; > +}; > + > &qup2 { > status = "okay"; > }; > @@ -158,6 +187,31 @@ &remoteproc_nsp1 { > status = "okay"; > }; > > +&tlmm { > + pcie3a_default: pcie3a-default {
Add suffix: -state
> + perst {
-pins
Same in other places.
Best regards, Krzysztof
| |