Messages in this thread | | | Date | Wed, 30 Nov 2022 07:53:08 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH v2] firmware/psci: demote suspend-mode warning to info level |
| |
On Wed, Oct 26, 2022 at 03:54:45PM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index e7bcfca4159f..f8fa32f0a130 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -165,7 +165,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > }
Mark and Lorenzo, I noticed this one hasn't been picked up yet. Is that something you will do or is Arnd supposed to take it?
Johan
| |