Messages in this thread | | | Date | Wed, 30 Nov 2022 11:43:39 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH linux-next] printk: use strscpy() to instead of strlcpy() |
| |
On Wed 2022-11-30 10:17:07, John Ogness wrote: > On 2022-11-30, <yang.yang29@zte.com.cn> wrote: > > From: Xu Panda <xu.panda@zte.com.cn> > > > > The implementation of strscpy() is more robust and safer. > > That's now the recommended way to copy NUL terminated strings. > > > > Signed-off-by: Xu Panda <xu.panda@zte.com.cn> > > Signed-off-by: Yang Yang <yang.yang29@zte.com> > > This looks fine, but I am wondering if we should also replace all > strncpy() usage as well. AFAICT they can all be replaced. It would also > avoid the manual termination in console_setup().
I agree that it would be nice to replace strncpy() as well. But it might be done in a separate patch.
Yang, Xu, would you like to do it, please?
Best Regards, Petr
| |