Messages in this thread | | | Date | Wed, 30 Nov 2022 11:26:09 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] can: ctucanfd: Drop obsolete dependency on COMPILE_TEST |
| |
On 24.11.2022 14:16:04, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz> > Cc: Ondrej Ille <ondrej.ille@gmail.com>
Applied to linux-can.
Thanks, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |