| Date | Wed, 30 Nov 2022 11:15:56 +0100 | Subject | Re: [PATCH 02/10] mm/hugetlb: Don't wait for migration entry during follow page | From | David Hildenbrand <> |
| |
On 29.11.22 20:35, Peter Xu wrote: > That's what the code does with !hugetlb pages, so we should logically do > the same for hugetlb, so migration entry will also be treated as no page. > > This is probably also the last piece in follow_page code that may sleep, > the last one should be removed in cf994dd8af27 ("mm/gup: remove > FOLL_MIGRATION", 2022-11-16).
We only have a handful of follow_page() calls left. Most relevant for hugetlb should only be the ones from mm/migrate.c.
So this is now just consistent with ordinary pages/THP.
Happy so see that gone.
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
|