lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v7 06/16] ufs: core: mcq: Configure resource regions
Date
Hi Asutosh,

On Tue, 2022-11-29 at 10:53 -0800, Asutosh Das wrote:
> Define the mcq resources and add support to ioremap
> the resource regions.
>
> Co-developed-by: Can Guo <quic_cang@quicinc.com>
> Signed-off-by: Can Guo <quic_cang@quicinc.com>
> Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> drivers/ufs/core/ufs-mcq.c | 3 ++
> drivers/ufs/core/ufshcd-priv.h | 8 ++++
> drivers/ufs/host/ufs-qcom.c | 103
> +++++++++++++++++++++++++++++++++++++++++
> include/ufs/ufshcd.h | 30 ++++++++++++
> 4 files changed, 144 insertions(+)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index bf08ec5..d6807e3 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -119,7 +119,10 @@ int ufshcd_mcq_init(struct ufs_hba *hba)
> int ret;
>
> ret = ufshcd_mcq_config_nr_queues(hba);
> + if (ret)
> + return ret;
>
> + ret = ufshcd_vops_mcq_config_resource(hba);
> return ret;
> }
>
> diff --git a/drivers/ufs/core/ufshcd-priv.h
> b/drivers/ufs/core/ufshcd-priv.h
> index 9368ba2..74cb17b9 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -227,6 +227,14 @@ static inline void
> ufshcd_vops_config_scaling_param(struct ufs_hba *hba,
> hba->vops->config_scaling_param(hba, p, data);
> }
>
> +static inline int ufshcd_vops_mcq_config_resource(struct ufs_hba
> *hba)
> +{
> + if (hba->vops && hba->vops->mcq_config_resource)
> + hba->vops->mcq_config_resource(hba);
>

Please correct:

return hba->vops->mcq_config_resource(hba);

> +
> + return -EOPNOTSUPP;
> +}
> +
>

Except this issue, I test this series pass on my platform. Thanks the
patch

Eddie

\
 
 \ /
  Last update: 2022-11-30 10:16    [W:0.049 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site