Messages in this thread | | | From | Hariprasad Kelam <> | Subject | Re: [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement get_fec_stats | Date | Wed, 30 Nov 2022 08:54:56 +0000 |
| |
On Tue, Nov 29, 2022 at 10:44:08AM +0530, Hariprasad Kelam wrote: > The current implementation is such that FEC statistics are reported as > part of ethtool statistics that is the user can fetch them from the > below command > > "ethtool -S eth0" > > Fec Corrected Errors: > Fec Uncorrected Errors: > > This patch removes this logic
What might break the ABI, if anybody is using these statistics, or has a dumb parser and just looks at entry 42 which is now a different entry.
So i think you need to keep these two, and additionally report them the correct way via get_fec_stats.
Make sense, that's a good point . will wait for a day for other feedback and submit V3.
Thanks, Hariprasad k
Andrew
| |