lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v10 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie
Hi,

On Tue, Nov 29, 2022 at 10:30 PM Owen Yang <ecs.taipeikernel@gmail.com> wrote:
>
> +&pm8350c_pwm_backlight{
> + pwms = <&pm8350c_pwm 3 200000>;
> +};

This is in the right location now, but previously I mentioned that it
would be nice to have a comment explaining what you're doing. In other
words, I wish the above was something like:

&pm8350c_pwm_backlight{
/* Set the PWM period to 200 microseconds (5kHz duty cycle)
pwms = <&pm8350c_pwm 3 200000>;
};

If you spin a v11 with that change feel free to add my Reviewed-by tag.


-Doug

\
 
 \ /
  Last update: 2022-11-30 22:20    [W:0.035 / U:2.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site