lkml.org 
[lkml]   [2022]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: r8188eu: change return type of rtw_set_802_11_disassociate to void
From
Hi Phillip,

On 11/3/22 00:36, Phillip Potter wrote:
> Change return type of rtw_set_802_11_disassociate to void. This function
> always returns 'true' no matter what, so there is no need to return a
> value, and no need to check for it in the two call sites within
> rtw_wx_set_mlme.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/core/rtw_ioctl_set.c | 4 +---
> drivers/staging/r8188eu/include/rtw_ioctl_set.h | 2 +-
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 ++----
> 3 files changed, 4 insertions(+), 8 deletions(-)
>

<snip>

> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -1020,12 +1020,10 @@ static int rtw_wx_set_mlme(struct net_device *dev,
>
> switch (mlme->cmd) {
> case IW_MLME_DEAUTH:
> - if (!rtw_set_802_11_disassociate(padapter))
> - ret = -1;
> + rtw_set_802_11_disassociate(padapter);
> break;
> case IW_MLME_DISASSOC:
> - if (!rtw_set_802_11_disassociate(padapter))
> - ret = -1;
> + rtw_set_802_11_disassociate(padapter);
> break;
> default:
> return -EOPNOTSUPP;

You could also remove the ret variable and return 0 directly, since ret
is not changed anymore in the function.

regards,
Michael

\
 
 \ /
  Last update: 2022-11-03 06:38    [W:0.067 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site